Re: [PATCH 2/2] misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 28, 2024 at 7:24 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote:
>
> dtc generates the following warning when building the LAN966x devicetree
> overlay (lan966x_pci.dtso):
>   Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
>
> The oic interrupt parent is the PCI device itself. The PCI device node
> is the node on which the dtbo will be applied and this node already has
> properties needed.
>
> In order to remove the warning, add the missing properties in the
> overlay fragment node. Properties in this node will not be added when
> the overlay is applied (which is what we expect) but makes dtc happy.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@xxxxxxxxxxxxxxxx/
> Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> ---
> The referenced commit is in the reset tree
> ---
>  drivers/misc/lan966x_pci.dtso | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>





[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux