On Mon, Oct 28, 2024 at 7:24 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote: > > dtc generates the following warnings when building the LAN966x device > tree overlay (lan966x_pci.dtso): > Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property > Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property > Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property > > Indeed, related nodes are under the pci-ep-bus (simple-bus) which is not > correct. > > Put them outside this node. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@xxxxxxxxxxxxxxxx/ > Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device") > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> > --- > The referenced commit is in the reset tree > --- > drivers/misc/lan966x_pci.dtso | 36 +++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/misc/lan966x_pci.dtso b/drivers/misc/lan966x_pci.dtso > index 7282687df25f..5466d013da7d 100644 > --- a/drivers/misc/lan966x_pci.dtso > +++ b/drivers/misc/lan966x_pci.dtso > @@ -19,6 +19,24 @@ __overlay__ { > #address-cells = <3>; > #size-cells = <2>; > > + cpu_clk: cpu_clk { Preferred node name is "clock-<freq-in-hz>" Also, as a general rule, don't use "_" in node names (and properties). Isn't there a schema for the device which needs these nodes added to it? If not, there should be. Rob
