On 7/18/23 13:48, Michael Ellerman wrote:
Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes:
On Thu, Jul 13, 2023 at 09:11:10AM -0700, Randy Dunlap wrote:
on ppc64:
In file included from ../include/linux/device.h:15,
from ../arch/powerpc/include/asm/io.h:22,
from ../include/linux/io.h:13,
from ../include/linux/irq.h:20,
from ../arch/powerpc/include/asm/hardirq.h:6,
from ../include/linux/hardirq.h:11,
from ../include/linux/interrupt.h:11,
from ../drivers/video/fbdev/ps3fb.c:25:
../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe':
../drivers/video/fbdev/ps3fb.c:1172:40: error: 'struct fb_info' has no member named 'dev'
1172 | dev_driver_string(info->dev), dev_name(info->dev),
| ^~
../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
| ^~~~~~~~
../drivers/video/fbdev/ps3fb.c:1172:61: error: 'struct fb_info' has no member named 'dev'
1172 | dev_driver_string(info->dev), dev_name(info->dev),
| ^~
../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
| ^~~~~~~~
Hmm, there is no response from Thomas yet. I guess we should go with
reverting bdb616479eff419, right? Regardless, I'm adding this build regression
to regzbot so that parties involved are aware of it:
#regzbot ^introduced: bdb616479eff419
#regzbot title: build regression in PS3 framebuffer
Does regzbot track issues in linux-next?
They're not really regressions because they're not in a release yet.
Anyway I don't see where bdb616479eff419 comes from.
The issue was introduced by:
701d2054fa31 fbdev: Make support for userspace interfaces configurable
The driver seems to only use info->dev in that one dev_info() line,
which seems purely cosmetic, so I think it could just be removed, eg:
diff --git a/drivers/video/fbdev/ps3fb.c b/drivers/video/fbdev/ps3fb.c
index d4abcf8aff75..a304a39d712b 100644
--- a/drivers/video/fbdev/ps3fb.c
+++ b/drivers/video/fbdev/ps3fb.c
@@ -1168,8 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev)
ps3_system_bus_set_drvdata(dev, info);
- dev_info(info->device, "%s %s, using %u KiB of video memory\n",
- dev_driver_string(info->dev), dev_name(info->dev),
+ dev_info(info->device, "using %u KiB of video memory\n",
info->fix.smem_len >> 10);
task = kthread_run(ps3fbd, info, DEVICE_NAME);
Can you please resend this as proper patch to fbdev and/or drm-misc mailing lists?
As it is, it never showed up for me in patchwork...
Helge
