On 18.07.23 18:15, Randy Dunlap wrote: > On 7/18/23 04:48, Michael Ellerman wrote: >> Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes: >>> On Thu, Jul 13, 2023 at 09:11:10AM -0700, Randy Dunlap wrote: >>>> on ppc64: >>>> >>>> In file included from ../include/linux/device.h:15, >>>> from ../arch/powerpc/include/asm/io.h:22, >>>> from ../include/linux/io.h:13, >>>> from ../include/linux/irq.h:20, >>>> from ../arch/powerpc/include/asm/hardirq.h:6, >>>> from ../include/linux/hardirq.h:11, >>>> from ../include/linux/interrupt.h:11, >>>> from ../drivers/video/fbdev/ps3fb.c:25: >>>> ../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe': >>>> ../drivers/video/fbdev/ps3fb.c:1172:40: error: 'struct fb_info' has no member named 'dev' > [...] >> >> Does regzbot track issues in linux-next? Seems your patch didn't make any progress, at least I can't see it in -next. Is there a reason why, or did I miss anything? And yes, sure, I'm aware that it's -next and a driver that people might not enable regularly. But I noticed it and thought "quickly bring it up, might be good to fix this rather sooner than later before other people run into it (and who knows, maybe it'll switch a light in some CI system from red to green as well)" Ciao, Thorsten >> The driver seems to only use info->dev in that one dev_info() line, >> which seems purely cosmetic, so I think it could just be removed, eg: >> >> diff --git a/drivers/video/fbdev/ps3fb.c b/drivers/video/fbdev/ps3fb.c >> index d4abcf8aff75..a304a39d712b 100644 >> --- a/drivers/video/fbdev/ps3fb.c >> +++ b/drivers/video/fbdev/ps3fb.c >> @@ -1168,8 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev) >> >> ps3_system_bus_set_drvdata(dev, info); >> >> - dev_info(info->device, "%s %s, using %u KiB of video memory\n", >> - dev_driver_string(info->dev), dev_name(info->dev), >> + dev_info(info->device, "using %u KiB of video memory\n", >> info->fix.smem_len >> 10); >> >> task = kthread_run(ps3fbd, info, DEVICE_NAME); > > > Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested > > Thanks. >
