Re: [BUG -next] "memcg: charge before adding to swapcache on swapin" broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 17, 2021 at 6:31 PM Minchan Kim <minchan@xxxxxxxxxx> wrote:
>
[...]
> >
> > The simplest solution I can think of is to do set_page_private(page,
> > entry.val) before swap_readpage(page, true) and set_page_private(page,
> > 0) after.
>
> Since I did't read the bug in detail, I couldn't come up with how the
> missing reset is connected the problem while missing set_page_private
> with entry.val is clear.

This particular bug is about missing set_page_private(page,
entry.val). I was wondering if we should always reset page->private or
just leave it as is? I think it is safer to reset.



[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux