On Thu, Jul 30, 2020 at 4:00 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 29, 2020 at 06:04:57PM +0300, Andy Shevchenko wrote: > > On Wed, Jul 29, 2020 at 4:35 PM Waiman Long <longman@xxxxxxxxxx> wrote: > > > On 7/29/20 8:28 AM, Herbert Xu wrote: > > > > ... > > > > > This patch series looks good to me. I just wonder if we should also move > > > ATOMIC64_INIT() to types.h for symmetry purpose. Anyway, > > > > Same question here. > > Yes I almost started doing it but at least one architecture (arc) > had a custom atomic64_t so I kept it out just to be on the safe > side. We may ask Synopsys folks to look at this as well. Vineet, any ideas if we may unify ATOMIC64_INIT() across the architectures? > We certainly could do this as a follow-up patch. -- With Best Regards, Andy Shevchenko