Hi Geert, On 2019/10/23 14:44, Geert Uytterhoeven wrote: > On Wed, Oct 23, 2019 at 8:17 AM Shaokun Zhang > <zhangshaokun@xxxxxxxxxxxxx> wrote: >> +Cc: Mark Salyzyn >> >> There is a compiler failure on arm64 platform, as follow: >> zhangshaokun@ubuntu:~/linux-next$ make -j64 >> CALL scripts/atomic/check-atomics.sh >> CC arch/arm64/kernel/asm-offsets.s >> In file included from ./include/linux/sysctl.h:30:0, >> from ./include/linux/umh.h:9, >> from ./include/linux/kmod.h:9, >> from ./include/linux/module.h:13, >> from ./include/linux/acpi.h:29, >> from ./include/acpi/apei.h:9, >> from ./include/acpi/ghes.h:5, >> from ./include/linux/arm_sdei.h:8, >> from arch/arm64/kernel/asm-offsets.c:10: >> ./include/uapi/linux/sysctl.h:561:29: error: expected ‘,’ or ‘}’ before ‘__attribute__’ >> NET_IPV6_TEMP_PREFERED_LFT __attribute__((deprecated)) = /* NOTYPO */ >> ^ >> scripts/Makefile.build:99: recipe for target 'arch/arm64/kernel/asm-offsets.s' failed >> make[1]: *** [arch/arm64/kernel/asm-offsets.s] Error 1 >> Makefile:1108: recipe for target 'prepare0' failed >> make: *** [prepare0] Error 2 >> >> It's the commit <79f0cf35dccb> ("treewide: cleanup: replace prefered with preferred"). > > After receiving a report from kisskb for failures for m68k, looking at > http://kisskb.ellerman.id.au/kisskb/head/f3c452cfc59c817950b150b51ec2b33409d7640b/ > and doing some testing, it looks like this construct is supported by gcc-7 > and gcc-8, but not by gcc-4.6.3 and gcc-5. Don't know about gcc-6. > GCC version is 5.4.0 zhangshaokun@ubuntu:~/linux-next$ gcc --version gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Thanks, > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > > . >