On 2019/7/8 12:17 Vinod Koul <vkoul@xxxxxxxxxx> wrote: > On 08-07-19, 11:06, zhangfei wrote: > > Hi, Robin > > > > On 2019/7/8 上午9:22, Robin Gong wrote: > > > Hi Stephen, > > > That's caused by 'of_irq_count' NOT export to global symbol, and > > > I'm curious why it has been here for so long since Zhangfei found it > > > in 2015. > > I remembered Rob suggested us not using of_irq_count and use > > platform_get_irq etc. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml > > .org%2Flkml%2F2015%2F11%2F18%2F466&data=02%7C01%7Cyibin.go > ng%40nxp > > .com%7Cb6d84a6976d7457dc34408d7035baaf5%7C686ea1d3bc2b4c6fa92 > cd99c5c30 > > > 1635%7C0%7C0%7C636981564557143537&sdata=jEgFnB3YNkVtsigfbN6 > XGJojlb > > JAyOi8kiGd5JHJEcM%3D&reserved=0 > > The explanation looks sane to me, so it makes sense to revert the commit for > now. Reverted now Ok, I will send v6 with the fix.