On 2019/7/8 11:06 AM, zhangfei <zhangfei.gao@xxxxxxxxxx> wrote: > Hi, Robin > > On 2019/7/8 上午9:22, Robin Gong wrote: > > Hi Stephen, > > That's caused by 'of_irq_count' NOT export to global symbol, and I'm > > curious why it has been here for so long since Zhangfei found it in > > 2015. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > hwork.kernel.org%2Fpatch%2F7404681%2F&data=02%7C01%7Cyibin.gon > g%40 > > > nxp.com%7C5917e41babe84d562d4708d703514ed8%7C686ea1d3bc2b4c6fa > 92cd99c5 > > > c301635%7C0%7C0%7C636981520060417930&sdata=QwPjifxeCEJmlrk0 > 2Ne71Bb > > hSgsZNLLgx7PnO81MHmA%3D&reserved=0 > > Hi Rob, > > Is there something I miss so that Zhangfei's patch not accepted finally? > > > > > > I remembered Rob suggested us not using of_irq_count and use > platform_get_irq etc. > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org > %2Flkml%2F2015%2F11%2F18%2F466&data=02%7C01%7Cyibin.gong%4 > 0nxp.com%7C5917e41babe84d562d4708d703514ed8%7C686ea1d3bc2b4c6f > a92cd99c5c301635%7C0%7C0%7C636981520060417930&sdata=g2mNB > 33%2Ba09JIpXot6j0w%2FV30grSVCt1GxZJCHyEgiM%3D&reserved=0 > > So we remove of_irq_count > commit 8c77dca011125b795bfa1c86f85a80132feee578 > Author: John Garry <john.garry@xxxxxxxxxx> > Date: Thu Nov 19 20:23:59 2015 +0800 > > hisi_sas: Remove dependency on of_irq_count > > Thanks Thank Fei for your kind information:)