Hi all, Today's linux-next merge of the net-next tree got conflicts in: drivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_nic.h between commit: 48dd73d08d4d ("net: aquantia: fix vlans not working over bridged network") from the net tree and commit: d3ed7c5cf79b ("net: aquantia: adding fields and device features for vlan offload") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 41172fbebddd,746f85e6de13..000000000000 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@@ -126,7 -126,8 +126,9 @@@ void aq_nic_cfg_start(struct aq_nic_s * cfg->link_speed_msk &= cfg->aq_hw_caps->link_speed_msk; cfg->features = cfg->aq_hw_caps->hw_features; + cfg->is_vlan_force_promisc = true; + cfg->is_vlan_rx_strip = !!(cfg->features & NETIF_F_HW_VLAN_CTAG_RX); + cfg->is_vlan_tx_insert = !!(cfg->features & NETIF_F_HW_VLAN_CTAG_TX); } static int aq_nic_update_link_status(struct aq_nic_s *self) diff --cc drivers/net/ethernet/aquantia/atlantic/aq_nic.h index 0f22f5d5691b,26c72f298684..000000000000 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.h +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.h @@@ -35,7 -35,8 +35,9 @@@ struct aq_nic_cfg_s u32 flow_control; u32 link_speed_msk; u32 wol; + bool is_vlan_force_promisc; + u8 is_vlan_rx_strip; + u8 is_vlan_tx_insert; u16 is_mc_list_enabled; u16 mc_list_count; bool is_autoneg;
Attachment:
pgp2_lzsXaIJe.pgp
Description: OpenPGP digital signature