Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
net/ipv4/ip_output.c
between commit:
5b18f1289808 ("ipv4: reset rt_iif for recirculated mcast/bcast out pkts")
from the net tree and commit:
956fe2190820 ("bpf: Update BPF_CGROUP_RUN_PROG_INET_EGRESS calls")
from the net-next tree.
I fixed it up (I think - see below) and can carry the fix as necessary.
This is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc net/ipv4/ip_output.c
index 8c2ec35b6512,cdd6c3418b9e..000000000000
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@@ -322,7 -330,12 +331,26 @@@ static int ip_mc_finish_output(struct n
int ret;
ret = BPF_CGROUP_RUN_PROG_INET_EGRESS(sk, skb);
- if (ret) {
+ switch (ret) {
++ case NET_XMIT_SUCCESS:
++ case NET_XMIT_CN:
++ /* Reset rt_iif so that inet_iif() will return skb->skb_iif.
++ * Setting this to non-zero causes ipi_ifindex in in_pktinfo
++ * to be overwritten, see ipv4_pktinfo_prepare().
++ */
++ new_rt = rt_dst_clone(net->loopback_dev, skb_rtable(skb));
++ if (new_rt) {
++ new_rt->rt_iif = 0;
++ skb_dst_drop(skb);
++ skb_dst_set(skb, &new_rt->dst);
++ }
++ }
++ switch (ret) {
+ case NET_XMIT_SUCCESS:
+ return dev_loopback_xmit(net, sk, skb);
+ case NET_XMIT_CN:
+ return dev_loopback_xmit(net, sk, skb) ? : ret;
+ default:
kfree_skb(skb);
return ret;
}
Attachment:
pgpV7tzOoUeq1.pgp
Description: OpenPGP digital signature
