Hi Stefan/Mark,
On 02/08/18 08:44, Stefan Wahren wrote:
Hi Srinivas,
Am 02.08.2018 um 09:28 schrieb Srinivas Kandagatla:
Hi Stefan,
On 01/08/18 20:11, Stefan Wahren wrote:
bb4b894addb09a069c072a0a032f644cc470d17f is the first bad commit
commit bb4b894addb09a069c072a0a032f644cc470d17f
Author: Srinivas Kandagatla<srinivas.kandagatla@xxxxxxxxxx>
Date: Fri Jul 13 16:36:28 2018 +0100
ASoC: core: add support to card re-bind using component framework
This patch aims at achieving dynamic behaviour of audio card when
the dependent components disappear and reappear.
i can confirm this after a manual bisect.
(something in your mail client or workflow mangled the commit log
here).
I'm somewhat suspicious of this result given that that commit has been
in -next rather longer than one day
The boot issue exists in sound/for-next since 2018-07-18 [1], which
is shortly after this commit.
and the board doesn't visibly have a
sound card in mainline (there are some I2S controllers in there but no
card to use them).
The BCM2835 has HDMI Audio from vc4_hdmi. After removing the
dma-channel "audio-rx" from the DTS the RPi boots properly even with
the patch above.
Any ideas to investigate the issue further?
When it does not boot, does it hang/deadlock or do we have a crash
report?
it hangs / deadlock endlessly. I didn't see any crash.
I can confirm that this is a deadlock due to this patch,
This happens due to a big mutex lock in component framework which keeps
hold of it when a component is added, removed or bind/unbind callback is
invoked.
Looks like the vc4_hdmi is path is invoked as part of component fw
component_bind_all() callback which then inside this big lock calls
devm_snd_soc_register_component() which does component_add which trys to
take the mutex which is when it gets dead lock.
Mark, am not sure what is the best way to go, but I would suggest to
remove this offending patch, I will rework on this in the mean time, or
try to see if component framework can be made more flexible to handle
such use-cases.
Sorry for not testing all the possible usecases due to limitation of
hardware!
Thanks,
srini
It is not obvious from the bootlog from
https://storage.kernelci.org/next/master/next-20180731/arm/bcm2835_defconfig/lab-baylibre/boot-bcm2837-rpi-3-b.txt
--srini
Best regards
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
