Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > + wait_var_event(&rxnet->nr_calls, !atomic_read(&rxnet->nr_calls)); I would prefer == 0 to ! as it's not really a true/false value. But apart from that, it's looks okay and you can add my Reviewed-by. David -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html