On (10/06/16 06:11), Eric Dumazet wrote: > On Wed, 2016-10-05 at 22:56 +0200, Michal Sojka wrote: > > > this commit is now in mainline as > > e3b37f11e6e4e6b6f02cc762f182ce233d2c1c9d and it breaks my build: > > > > net/netfilter/core.c: In function 'nf_set_hooks_head': > > net/netfilter/core.c:96:3: error: 'struct net_device' has no member named 'nf_hooks_ingress' > > > > Are the fixes (see below) on the way to mainline too? > > Yes the fixes are already in nf tree and _will_ get pushed. > > Pablo and David are attending netdev 1.2 in Tokyo and have obligations. > > https://git.kernel.org/cgit/linux/kernel/git/pablo/nf-next.git/ well, I did my best to avoid it, but the guys didn't even bother to reply. pushing a knowingly broken patch that a) kills the build b) introduces a race c) requires two "Fixes:" followup patches to the main line despite the fact that those problems were discovered at linux-next stage is totally un-cool. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html