Re: Removal of GENERIC_GPIO breaks -next

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/17/2013 04:07 PM, Alexandre Courbot wrote:
> 
> Also arch/arc/plat-tb10x/Kconfig now defines GENERIC_GPIO, this will
> not cause breakage but should not be here anymore (ideally removed by
> the "Remove GENERIC_GPIO config option" patch)
> 
> Apart from these two issues, things seem to have gone fine, but I'm
> not sure how they should be addressed and by who?

For the arc issue - I thought we'd come to consensus already. Quoting your earlier
email:

"If the only reference to GENERIC_GPIO in your architecture or drivers is the
declaration of this config option, then it is perfectly fine - I will take care of
removing it when the time is right."

Anyhow it's a minor issue - since your code is in -next, maybe you can add the
following patch to your branch - rather than routing via my tree - better for
bisectablity. I compile tested here !

------------------->
From: Vineet Gupta <vgupta@xxxxxxxxxxxx>
Date: Wed, 17 Apr 2013 17:33:02 +0530
Subject: [PATCH] ARC: [TB10x] Remove GENERIC_GPIO

This tracks Alexandre Courbot's mainline GPIO rework

Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>
---
 arch/arc/plat-tb10x/Kconfig |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arc/plat-tb10x/Kconfig b/arch/arc/plat-tb10x/Kconfig
index 4e12127..1d34521 100644
--- a/arch/arc/plat-tb10x/Kconfig
+++ b/arch/arc/plat-tb10x/Kconfig
@@ -27,10 +27,3 @@ menuconfig ARC_PLAT_TB10X
 	  Abilis Systems. TB10x is based on the ARC700 CPU architecture.
 	  Say Y if you are building a kernel for one of the SOCs in this
 	  series (e.g. TB100 or TB101). If in doubt say N.
-
-if ARC_PLAT_TB10X
-
-config GENERIC_GPIO
-	def_bool y
-
-endif
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux