On Fri, 2012-03-23 at 15:50 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2012-03-23 at 13:00 +1100, Stephen Rothwell wrote: > > Hi James, > > > > After merging the scsi tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > drivers/ata/sata_svw.c: In function 'k2_sata_proc_open': > > drivers/ata/sata_svw.c:327:2: error: implicit declaration of function 'PDE' [-Werror=implicit-function-declaration] > > drivers/ata/sata_svw.c:327:56: error: invalid type argument of '->' (have 'int') > > drivers/ata/sata_svw.c:328:1: warning: control reaches end of non-void function [-Wreturn-type] > > > > Caused by commit 343ac4b031a7 ("[SCSI] sata_svw: convert to scsi proc_ops"). > > > > I have used the scsi tree from next-20120322 for today. > > Additionally, I am the author and maintainer of that driver and I don't > remember ever being CCed on that patch ... or did I miss it ? You missed it ... I added you and Jeff for automatic cc's when the commit hit the scsi tree. This is the mail log: Mar 22 07:53:17 bedivere postfix/smtp[14322]: C3A1F8EE136: to=<benh@xxxxxxxxxxxxxxxxxxx>, relay=gate.crashing.org[63.228.1.57]:25, delay=2.7, delays=0.13/0.12/1.3/1.2, dsn=2.0.0, status=sent (250 2.0.0 q2MErGNT019145 Message accepted for delivery) James -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html