On Tue, Mar 6, 2012 at 2:55 PM, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > On Tue, Mar 6, 2012 at 11:16 AM, Mark Salter <msalter@xxxxxxxxxx> wrote: >> On Tue, 2012-03-06 at 16:02 +0000, Arnd Bergmann wrote: >>> On Tuesday 06 March 2012, Mark Salter wrote: >>> > I'm seeing a build failure in lib/string.h in linux-next: >>> > >>> > /es/linux/linux-next/lib/string.c: In function 'strlcat': >>> > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'printk' >>> > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'panic' >>> > >>> > Commit e2950c2b6ecb928bfd3a13dd237df1f29f712704 removed an include of >>> > linux/module.h which triggered the problem for arch/c6x and probably >>> > other architectures using the asm-generic BUG macro. >>> > >>> > I think this needs fixing in asm-generic/bug.h which should include >>> > linux/kernel.h for panic and linux/printk.h for printk. >>> >>> I think you cannot do that as long as linux/kernel.h includes asm/bug.h, >>> or you will get a lot of other build failures. >> >> It didn't for my build, but to tell the truth, I really wasn't too keen >> on adding an include of kernel.h to asm/bug.h since kernel.h pulls in so >> much other stuff. >> >>> >>> The safer option is probably to add the two missing headers separately >>> to string.c. >> >> Okay, I can put together a patch that does that. > > I can deal with this, since it is interaction between my bug commits and my > module commits that trigger it. Can you tell me what config you are using, so > I can double check I have it sorted properly? Never mind the config. I missed the arch/c6x initially. I've got a c6x toolchain now and can reproduce it with the dsk6455_defconfig. Will be fixed for this evening's linux-next. Thanks for the report. Paul. > Thanks. > Paul. > >> >> --Mark >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
