Hi Greg Sorry, for inconvenience. I'll re-submit ASAP. thanks -- ROHM Co., Ltd. tomoya 2012年3月6日1:43 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Sat, Mar 03, 2012 at 10:41:42AM +1100, Stephen Rothwell wrote: >> [Just cc'ing Greg as this commit is in the usb tree] >> >> On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: >> > >> > This commit: >> > >> > --------------- >> > commit 637b78eb31e0b167ed913f1750bb645dfeda38f0 >> > Author: Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx> >> > Date: Fri Feb 3 16:14:18 2012 +0900 >> > >> > usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt >> > >> > Problem: >> > pch_udc continues operation even if VBUS becomes Low. >> > pch_udc performs D+ pulling up before VBUS becomes High. >> > USB device should be controlled according to VBUS state. >> > >> > Root cause: >> > The current pch_udc is not always monitoring VBUS. >> > >> > Solution: >> > The change of VBUS is detected using an interrupt of GPIO. >> > If VBUS became Low, pch_udc handles 'disconnect'. >> > After VBUS became High, a pull improves D+, and pch_udc >> > handles 'connect'. >> > >> > [ balbi@xxxxxx : make it actually compile ] >> > >> > Signed-off-by: Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx> >> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> >> > --------------- >> > >> > breaks the sparc builds in next: >> > >> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/ >> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/ > > Ick, not good. > > Tomoya, can you please send me a patch to fix this? Felipe is off-line > for a few days and can't do this himself. > > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html