On Mon, 2012-02-27 at 17:37 +1100, Stephen Rothwell wrote: > pci_add_resource_offset(resources, res, > - (resource_size_t) hose->io_base_virt - _IO_BASE); > + (resource_size_t)(unsigned long)hose->io_base_virt - _IO_BASE); We have to be careful here as we do want sign extension to happen (yeah it's odd, but it's the way we do IOs on ppc32 :-) Maybe I should change it one day). So we probably want to do: (resource_size_t)(long long)(hose->io_base_virt - _IO_BASE) Basically, IO resources are relative to _IO_BASE which on ppc32 is basically the virtual address where we map the first PHB IO space. Subsequent PHB mappings can end up below _IO_BASE, leading to negative resource values for IO BARs on those busses. It all works fine because even an unsigned addition will do the right thing as long as the value is fully sign extended. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
