On Fri, Feb 17, 2012 at 05:32:10PM +0400, Konstantin Khlebnikov wrote: > Stephen Rothwell wrote: >> Hi Konstantin, >> >> On Fri, 17 Feb 2012 16:08:15 +0400 Konstantin Khlebnikov<khlebnikov@xxxxxxxxxx> wrote: >>> >>> Config NUMA must be defined for all architectures, >>> otherwise IS_ENABLED(CONFIG_NUMA) does not work. >>> Some arch-specific Kconfig already has this stub. >>> This patch adds it to all remaining. >> >> Why not add it somewhere generic (like mm/Kconfig, maybe) and then it can >> be removed from the architecture specific places over time (if necessary >> - I am pretty sure it is ok to have it there twice)? >> > > Different architectures has different dependencies for NUMA. > > Seems like Kconfig allow config option duplication, but it use default state from first. > If we add "config NUMA\n def_bool n" somewhere in generic Kconfig, default will be n if > Kconfig see this declaration first. Correct. And as n is default there is no need to specify it. But please add a help text that explain the symbol - even if it is not visible in menuconfig. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
