On Mon, Feb 13, 2012 at 08:48:05AM -0600, Seth Jennings wrote: > On 02/13/2012 12:45 AM, Greg KH wrote: > > On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote: > >> Hi , > >> > >> After merging the final tree, today's linux-next build (powerpc allyesconfig) > >> failed like this: > >> > >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier': > >> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration] > >> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default] > >> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration] > >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object': > >> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration] > >> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type > >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object': > >> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration] > >> > >> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory > >> allocation library"). This needs to include linux/vmalloc.h at least. I > >> couldn't find set_pte at all or __flush_tlb_one for powerpc. > >> > >> This was too hard to revert, so I have left powerpc allyesconfig broken > >> for today. I may revert it (and some dependent commits) tomorrow. > > > > Nitin, please send me a patch to fix this as soon as possible. > > Sending a patch now. Adds linux/vmalloc.h to zsmalloc-main.c. On a less ideal > note, it also adds an X86 dependency since set_pte and __flush_tlb_one are > x86 only. I'm working to find portable replacements for these functions. Thanks for the patch, I'll queue it up. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html