-----Original Message----- From: glikely@xxxxxxxxxxxx [mailto:glikely@xxxxxxxxxxxx] On Behalf Of Grant Likely Sent: Thursday, December 15, 2011 11:55 PM To: Ashish Jangam Cc: Stephen Rothwell; linux-next@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Mark Brown; Dajun Subject: Re: linux-next: build failure after merge of the regmap tree On Thu, Dec 15, 2011 at 2:25 AM, Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx> wrote: > Fixes DA9052 GPIO errors. > > This patch is functionally tested on Samsung SMDKV6410. > > Signed-off-by: David Dajun Chen <dchen@xxxxxxxxxxx> > Signed-off-by: Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx> > --- > drivers/gpio/gpio-da9052.c | 37 ++++-------------------------- > include/linux/mfd/da9052/gpio.h | 48 +++++++++++++++++++++++++++++++++++++++ gpio-da9052.c is the only users of mfd/da9052/gpio.h. Why is this include file needed? The #defines can simply stay in the .c file. I've picked up the patch, but modified it to keep the header defines in the .c file. If there is a reason this won't work, then please let me know. This header file is shared between GPIO and LED module. I have already posted this LED long back got ACK but did not got merged due to its dependency on MFD module. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
