Re: linux-next: build failure in drivers/mfd/aat2870-core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Paul

I have checked aat2870-core.c build problem when x86_64 and got the
same error with you.

This error occurred since merged below change.
----------------------------------------------------------------------------------
commit da417bacc9143b934f1a480a25d0fb2bb648a820
Author: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
Date:   Wed Sep 28 10:50:29 2011 +1000

    x86: implement strict user copy checks for x86_64
----------------------------------------------------------------------------------
The above change is check object size and copy size for
copy_from_user() to prevent overflow.

The root cause is not matched type of size parameter for
copy_from_user() in aat2870-core.c for x86_64.
Because I just passed int type for size parameter to copy_from_user().
It has no problem for i386, but has problem for x86_64.


This is the patch for this build problem. Please review it.

mfd: aat2870: Fix build failure for x86_64

Signed-off-by: Jin Park <jinyoungp@xxxxxxxxxx>
---
 drivers/mfd/aat2870-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
index 345dc65..02c4201 100644
--- a/drivers/mfd/aat2870-core.c
+++ b/drivers/mfd/aat2870-core.c
@@ -295,7 +295,7 @@ static ssize_t aat2870_reg_write_file(struct file *file,
 {
 	struct aat2870_data *aat2870 = file->private_data;
 	char buf[32];
-	int buf_size;
+	ssize_t buf_size;
 	char *start = buf;
 	unsigned long addr, val;
 	int ret;
-- 
1.7.1

Thanks,
Jin Park
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux