On Tue, Aug 23, 2011 at 11:59, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Aug 23, 2011 at 03:08:54PM +1000, Stephen Rothwell wrote: >> After merging the moduleh tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> drivers/usb/dwc3/dwc3-pci.c: In function 'dwc3_pci_init': >> drivers/usb/dwc3/dwc3-pci.c:211:9: error: 'THIS_MODULE' undeclared (first use in this function) >> >> Caused by the interaction of the module.h split up with commit >> 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver") from the usb >> tree. >> >> I have applied this patch for today (Greg, this should be applied to your >> tree): >> >> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> >> Date: Tue, 23 Aug 2011 15:05:25 +1000 >> Subject: [PATCH] usb: include module.h in the DesignWare USB3 DRD driver >> >> Fixes this build error: >> >> drivers/usb/dwc3/dwc3-pci.c: In function 'dwc3_pci_init': >> drivers/usb/dwc3/dwc3-pci.c:211:9: error: 'THIS_MODULE' undeclared (first use in this function) >> >> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> >> --- >> drivers/usb/dwc3/dwc3-pci.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c >> index 2578595..e3b77d2 100644 >> --- a/drivers/usb/dwc3/dwc3-pci.c >> +++ b/drivers/usb/dwc3/dwc3-pci.c >> @@ -38,6 +38,7 @@ >> */ >> >> #include <linux/kernel.h> >> +#include <linux/module.h> > > that was my fault, I didn't know about Paul's commit. Please Greg, apply > this to your tree: > > Acked-by: Felipe Balbi <balbi@xxxxxx> The include should also be added to drivers/usb/dwc3/core.c and drivers/usb/dwc3/dwc3-omap.c, cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/4491952/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html