On Fri, 6 May 2011, Linus Walleij wrote: > 2011/5/5 Jiri Kosina <jkosina@xxxxxxx>: > > On Fri, 29 Apr 2011, Linus Walleij wrote: > >> > >> I rewrote the driver completely so likely it will rather be dropped, but > >> please check! I'll be happy to carry any patches. > > > > Seems to me that all the calls to request_mem_region() and > > release_mem_region() still need the resource_size() fixup even in the new > > driver. > > OK I went in and tweaked the patch like this: > > if (request_mem_region(gpio->memres->start, > resource_size(gpio->memres), > "GPIO Controller") > == NULL) { > dev_err(gpio->dev, "could not reserve GPIO memory region\n"); > err = -ENODEV; > goto err_no_ioregion; > } > (...) > err_no_ioremap: > release_mem_region(gpio->memres->start, resource_size(gpio->memres)); > (...) > release_mem_region(gpio->memres->start, > resource_size(gpio->memres)); > > It'll appear in the next tree tomorrow or so. OK? Thanks. I have dropped Joe's patch from my queue now. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html