On Mon, Sep 27, 2010 at 08:38:50PM +0200, Ohad Ben-Cohen wrote: > On Mon, Sep 27, 2010 at 8:25 PM, John W. Linville > <linville@xxxxxxxxxxxxx> wrote: > >> BTW, if this fuglet going to work if the driver is built modular? > >> > >> The idea of this things seems to be to allow arch platform code to call > >> into it to set things. Such calls from arch platform code are going > >> to be "obj-y" > >> > >> So if this is built into the modular driver, I can't see how it > >> can work. > > > > Dave is right -- these Kconfig dependencies (or lack thereof) seem > > to be wrong. > > This is why I had to put it in drivers/net/wireless/Makefile (in both > the original patch and in the fix I sent earlier) and not in > drivers/net/wireless/wl12xx/Makefile (as it was in the fix that Dave > was referring to). > > This way it works with a modular driver. That doesn't seem very helpful if someone selects CONFIG_MACH_OMAP_ZOOM2=y CONFIG_WL12XX_PLATFORM_DATA=n or am I missing something? John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html