On Thursday 16 September 2010 08:54:39 Amit Shah wrote: > Arnd, the device is supposed to be non-seekable so I'll add a > nonseekable_open() to the open() call. > > So I guess the llseek operation should ne no_llseek instead of > noop_llseek. Will you change that in your patchset? Should I do that > in the patch I'll queue up? Yes, I think it's best if you just do both changes in your patch, I'll drop this file from my series then. Any driver that we can make use no_llseek instead of noop_llseek is a step forward. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html