On Wed, Jul 14, 2010 at 05:27:41PM -0700, Andrew Morton wrote: > On Thu, 15 Jul 2010 09:45:13 +1000 > Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > > Hi Andrew, Al, > > > > On Wed, 14 Jul 2010 15:20:42 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > Bug is still there. Reverting ""Make ->drop_inode() just return > > > whether inode needs to be dropped" makes it go away. > > > > > > Al, please don't just dump crap in linux-next and then ignore bug reports. > > > People are trying to get work done here. > > > > I will revert that commit in linux-next today if it is still there (and > > not fixed). > > Reverting the patch didn't help - the patch moved the BUG_ON() from > generic_delete_inode() into __iput_final(). With the patch reverted > the kernel still goes BUG over the same test in generic_delete_inode(). > > It could be that the bug was caused by fs-writeback.c changes. David, > do you have time to take a look at this? I'll have a look at it. What filesystem(s) are you seeing this on? Any particular workload that triggers it? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html