On Wed, 2009-12-16 at 14:23 -0800, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Fix gcc ISO C90 warning: > > fs/nfs/callback.c:356: warning: ISO C90 forbids mixed declarations and code > > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > --- > fs/nfs/callback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20091215.orig/fs/nfs/callback.c > +++ linux-next-20091215/fs/nfs/callback.c > @@ -352,8 +352,8 @@ static int check_gss_callback_principal( > static int nfs_callback_authenticate(struct svc_rqst *rqstp) > { > struct nfs_client *clp; > - RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); > int ret = SVC_OK; > + RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); > What version of gcc is giving rise to this warning? RPC_IFDEBUG is a macro that either evaluates to its argument, or to nothing, depending on whether or not RPC_DEBUG is defined or not. In neither case should it evaluate to anything illegal under C90 rules afaics. Trond -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html