Hi all,
On Wed, 22 Apr 2009 14:36:01 +0100 Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
>
> On Wed, Apr 22, 2009 at 03:33:11PM +0200, Johannes Berg wrote:
> > But that's not the interesting part -- the thing is the rfkill rewrite.
> > I don't know how to handle that w/o breaking all users. I had hoped to
> > finish this very soon to be ready early in .31, but I'm still waiting
> > for Thinkpad and Toshiba conversions (and I forgot who wanted to look at
> > Toshiba), but if new users are being added in other trees then that's a
> > problem.
>
> oqo-wmi can be ignored for the moment - Len, can you drop it from your
> tree for now? I'll clean that bit up as well.
So the rfkill rewrite has now hit the wireless tree, so today's build
(x86_64_allmodconfig) failure looks like this:
drivers/platform/x86/oqo-wmi.c:716: warning: 'enum rfkill_state' declared inside parameter list
drivers/platform/x86/oqo-wmi.c:716: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/platform/x86/oqo-wmi.c: In function 'oqo_rfkill_get':
drivers/platform/x86/oqo-wmi.c:727: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:727: error: 'RFKILL_STATE_SOFT_BLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c:729: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:729: error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c: At top level:
drivers/platform/x86/oqo-wmi.c:734: warning: 'enum rfkill_state' declared inside parameter list
drivers/platform/x86/oqo-wmi.c:734: error: parameter 2 ('state') has incomplete type
drivers/platform/x86/oqo-wmi.c: In function 'oqo_rfkill_toggle':
drivers/platform/x86/oqo-wmi.c:740: error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c: In function 'oqo_rfkill_init':
drivers/platform/x86/oqo-wmi.c:752: error: implicit declaration of function 'rfkill_allocate'
drivers/platform/x86/oqo-wmi.c:752: warning: assignment makes pointer from integer without a cast
drivers/platform/x86/oqo-wmi.c:759: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:761: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:761: error: 'RFKILL_STATE_SOFT_BLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c:763: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:763: error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c:765: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:766: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:767: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:772: error: implicit declaration of function 'rfkill_free'
So I have reverted commit 9c82cd255907ad639bed4ffc8fcaf1bd59badb50
("platform/x86: Add oqo-wmi driver for model 2 OQO backlight and rfkill
control") and commit 94c4b5977f33894cc316edf07c5cb72b5d193628 ("oqo:
dev_set_name()") that depend son it.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
Attachment:
pgpaACV3QbFgG.pgp
Description: PGP signature
