Tue, May 12, 2009 at 09:44:51AM CEST, sfr@xxxxxxxxxxxxxxxx wrote: >Hi Dave, > >This fixes it (I wonder if this bug is lurking in any other drivers): Grepping the sources I see some other places suffering this problem. I'll send patch for this. > >From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> >Date: Tue, 12 May 2009 17:24:02 +1000 >Subject: [PATCH] net/ibmveth: fix panic in probe > >netdev->dev_addr changed from being an array to being a pointer, so we >should not take its address for memcpy(). Nice! Signed-off-by: Jiri Pirko <jpirko@xxxxxxxxxx> > >Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> >--- > drivers/net/ibmveth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c >index 7902e5e..8daffad 100644 >--- a/drivers/net/ibmveth.c >+++ b/drivers/net/ibmveth.c >@@ -1285,7 +1285,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_ > netdev->features |= NETIF_F_LLTX; > spin_lock_init(&adapter->stats_lock); > >- memcpy(&netdev->dev_addr, &adapter->mac_addr, netdev->addr_len); >+ memcpy(netdev->dev_addr, &adapter->mac_addr, netdev->addr_len); > > for(i = 0; i<IbmVethNumBufferPools; i++) { > struct kobject *kobj = &adapter->rx_buff_pool[i].kobj; >-- >1.6.3 > > >-- >Cheers, >Stephen Rothwell sfr@xxxxxxxxxxxxxxxx >http://www.canb.auug.org.au/~sfr/ -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html