On Fri, Nov 21, 2008 at 09:27:52PM +0100, Takashi Iwai wrote: > At Fri, 21 Nov 2008 12:02:48 -0800, > Randy Dunlap wrote: > > > > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > > > First error comes from snd_hda_eld_proc_new() not being static > > when CONFIG_PROC_FS=n. After that is fixed, the next problem is: > > ERROR: "snd_print_pcm_rates" [sound/pci/hda/snd-hda-intel.ko] undefined! > > > > so I made a static inline version of that one too, for CONFIG_PROC_FS=n. > > Please build/test more config variations. > > > > LD [M] sound/pci/hda/snd-hda-intel.o > > sound/pci/hda/hda_eld.o: In function `snd_hda_eld_proc_new': > > (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > > sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > > sound/pci/hda/hda_hwdep.o: In function `snd_hda_eld_proc_new': [...] > > sound/pci/hda/patch_intelhdmi.o: In function `snd_hda_eld_proc_new': > > (.text+0x3b): multiple definition of `snd_hda_eld_proc_new' > > sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > > make[4]: *** [sound/pci/hda/snd-hda-intel.o] Error 1 > > > > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > cc: Wu Fengguang <wfg@xxxxxxxxxxxxxxx> > > cc: Takashi Iwai <tiwai@xxxxxxx> > > --- > > sound/pci/hda/hda_local.h | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > Thanks, but these have been differently fixed on the latest ALSA tree. > snd_print_pcm_*() have to be defined no matter what CONFIG_PROC_FS is. Thank you! I'll send another fix for remaining build warnings when CONFIG_PROC_FS=n. Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
