Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > + read_lock_irq(&tasklist_lock); > + psig = current->parent->sighand; > + spin_lock_irqsave(&psig->siglock, flags); There's no point using spin_lock_irqsave(): you've already disabled interrupts with read_lock_irq(). Similarly: > + spin_unlock_irqrestore(&psig->siglock, flags); > + read_unlock_irq(&tasklist_lock); spin_unlock_irqrestore() here is never going to re-enable interrupts. Apart from that, it looks okay. My tree and James's tree definitely need to meet before you see them. David -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html