Re: linux-next: v9fs patch comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks -- I've update my for-next branch as suggested and it looks
like I've got to go back and look through the rest of the code for
similar situations.

             -eric


On Wed, Oct 22, 2008 at 5:36 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Hi Eric,
>
>> commit d48be775412f4d9526da636754ebc108eac54b80
>> Author: Eric Van Hensbergen <ericvh@xxxxxxxxx>
>> Date:   Wed Oct 22 16:58:59 2008 -0500
>>
>>     9p: fix format warning
>>
>>     This patch fixes a format warning which appears on 64-bit builds.
>>
>>     Signed-off-by: Eric Van Hensbergen <ericvh@xxxxxxxxx>
>>
>> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
>> index 041c526..b218e23 100644
>> --- a/fs/9p/vfs_file.c
>> +++ b/fs/9p/vfs_file.c
>> @@ -178,7 +178,8 @@ v9fs_file_read(struct file *filp, char __user *udata, size_t count,
>>       int ret;
>>       struct p9_fid *fid;
>>
>> -     P9_DPRINTK(P9_DEBUG_VFS, "count %d offset %lld\n", count, *offset);
>> +     P9_DPRINTK(P9_DEBUG_VFS, "count %lu offset %lld\n",
>> +                                             (unsigned long) count, *offset);
>
> This is not the correct fix, you should use %zu to print size_t variables
> and then you don't need the cast.
>
> --
> Cheers,
> Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
> http://www.canb.auug.org.au/~sfr/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux