linux-next: v9fs patch comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric,

> commit d48be775412f4d9526da636754ebc108eac54b80
> Author: Eric Van Hensbergen <ericvh@xxxxxxxxx>
> Date:   Wed Oct 22 16:58:59 2008 -0500
> 
>     9p: fix format warning
>     
>     This patch fixes a format warning which appears on 64-bit builds.
>     
>     Signed-off-by: Eric Van Hensbergen <ericvh@xxxxxxxxx>
> 
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 041c526..b218e23 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -178,7 +178,8 @@ v9fs_file_read(struct file *filp, char __user *udata, size_t count,
>  	int ret;
>  	struct p9_fid *fid;
>  
> -	P9_DPRINTK(P9_DEBUG_VFS, "count %d offset %lld\n", count, *offset);
> +	P9_DPRINTK(P9_DEBUG_VFS, "count %lu offset %lld\n",
> +						(unsigned long) count, *offset);

This is not the correct fix, you should use %zu to print size_t variables
and then you don't need the cast.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp2usB3iRch5.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux