On Mon, Oct 20, 2008 at 09:51:42AM -0700, Greg KH wrote: > On Mon, Oct 20, 2008 at 12:33:29PM -0400, J.R. Mauro wrote: > > On Mon, Oct 20, 2008 at 11:48 AM, Greg KH <greg@xxxxxxxxx> wrote: > > > On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote: > > >> Hi Greg, > > >> > > >> Today's linux-next build (powerpc allyesconfig) failed like this: > > >> > > >> In file included from drivers/staging/sxg/sxg.c:77: > > >> drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation' > > >> drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet': > > >> drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function) > > >> drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER' > > >> drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast > > >> drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask': > > >> drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64' > > >> > > >> I applied the following patch. > > > > > > Ah, doh, sorry, I should have caught that. I'll go apply this to the > > > tree, thanks. > > > > Greg, > > > > The slicoss driver also from Alacritech looks like it needs a depends > > on X86 as well. Should the sxg and slicoss drivers from Alacritech be > > doing things like this (sxg/sxghif.h:851, slicoss/slicoss.c:960): > > Yes, it needs it too. Hm, it already has this dependancy. In drivers/staging/slicoss/Kconfig we have: config SLICOSS tristate "Alacritech Gigabit IS-NIC support" depends on PCI && X86 && NETDEV_1000 So we should be fine here. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
