Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes: > On Fri, 23 Oct 2009, Kevyn-Alexandre Paré wrote: > >> Just before I send my patch I got this error with: >> ./scripts/checkpatch.pl --terse --file >> 0001-Staging-comedi-driver-fix-coding-style.patch > > You're using checkpatch --file on a patch. I hope you don't intend your > patch to be added to the kernel source as a file, but rather applied to > the kernel source, changing other files. (I bet "gcc 0001-Staging*.patch" > will get interesting errors, too...) The patch format adds a single > character at the beginning of each line to say whether it's a addition, a > deletion, or a context line, and the context lines are identified by a > space character. This means that a blank context line consists of just > this space character, which is therefore a trailing space. We get the same > type of complaints when we have expected diff output in our test scripts. > > I'm kind of surprised that checkpatch doesn't completely blow up when it's > expecting a source file and getting a patch (and maybe tell you what > you've done). But that's the source of your errors, anyway. Ah, your analysis is correct. This is a usage error of checkpatch script and there is nothing for us to worry about. Thanks; I also failed to spot --file option when I responded. -- To unsubscribe from this list: send the line "unsubscribe linux-newbie" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.linux-learn.org/faqs
