* Willy Tarreau <w@xxxxxx> wrote: > On Fri, Oct 24, 2008 at 08:15:20PM -0700, Joe Damato wrote: > > Hi - > > > > This is my first submission to the kernel, so (beware!) please let me know if I can make any improvements on these patches. > > It looks like you provide one patch per file. You should group some > of them together so that each patch does a functional change and > everything still builds after incrementally applying that patch. The > way you have splitted them will break builds if someone tries to > build after patch 1 for instance. yes, at every step the kernel is expected to build and boot fine. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-newbie" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.linux-learn.org/faqs