hi joe, i am not a maintainer here so my comments are my private commonts so .. 1. this is a lot of work and thx for it patch 2/12: personaly i am not a fan of typedefs especially like this one: typedef struct gate_struct gate_desc; they make people think they move a int or something around that is a fat struct in real. do you really need a typedef ? or can you live with "struct gate_struct" instead ? (see: also http://www.linuxjournal.com/article/5780 section: typedef Is Evil ) patch 6/12 (same goes for others) is is possible to be more verbose ? what does l/d/g mean ? maybe an enum ? + desc->avl = flags & 0x1; + desc->l = (flags & 0x2) >> 1; + desc->d = (flags & 0x4) >> 2; + desc->g = (flags & 0x8) >> 3; i noticed you are accessing hi/lo often. you can use a macro like: from: highuid.h #define low_16_bits(x) ((x) & 0xFFFF) #define high_16_bits(x) (((x) & 0xFFFF0000) >> 16) or use a union { int foo; char bar[4]; } keep on going ... walter Joe Damato schrieb: > Hi - > > This is my first submission to the kernel, so (beware!) please let me know if I can make any improvements on these patches. > > I attempted to clean up the x86 structs for 32bit cpus that store IDT/LDT/GDT data by removing the fields labeled "a" and "b" in favor of more descriptive field names. I added some macros and went through the kernel cleaning up the various places where "a" and "b" were used. > > I tried building my kernel with my .config and then also did a make allyesconfig build to help ensure I found everything that was using the old structure names. I also tried a few grep patterns. Hopefully I got everyone out. > > > Thanks, > Joe Damato > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-newbie" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.linux-learn.org/faqs
