On Sun, May 22, 2005 at 05:18:17AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > > > BTW, icmpv6_send seems to ignore its dev argument altogether. > > Any reason why we can't just use it instead of skb->dev? > > (After looking into icmpv6_send() usages,) > I don't know the reason why we needed the last argument "dev". > It seems that we already had it at the time of 2.2.16. > Probably, we can remove it. In a number of places (I've just created another one with my patch :) we are setting skb->dev specifically for icmpv6_send. If we make icmpv6_send use its dev argument instead of skb->dev then we can avoid those settings. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - : send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
