In article <20050521194932.GA10959@xxxxxxxxxxxxxxxxxxx> (at Sun, 22 May 2005 05:49:32 +1000), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says: > On Sat, May 21, 2005 at 07:10:11PM +0000, Christophe Saout wrote: > > > > The oops occurs in line 391 in net/ipv6/icmp.c: > > > > > idev = in6_dev_get(skb->dev); > > Here is a minimal fix. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Acked-by: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx> > BTW, icmpv6_send seems to ignore its dev argument altogether. > Any reason why we can't just use it instead of skb->dev? (After looking into icmpv6_send() usages,) I don't know the reason why we needed the last argument "dev". It seems that we already had it at the time of 2.2.16. Probably, we can remove it. --yoshfuji - : send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
