On Tue, Apr 19, 2005 at 09:56:48AM -0400, Benjamin LaHaise wrote:
> At the very least your patch doesn't do a thorough enough job of
> removing the dead code -- there is no good reason to move the unused
> code into ns83820.c.
Where does my patch do this?
Only the one actually used function setup_ee_mem_bitbanger is moved to
ns83820.c .
> Also, someone needs to go around refactoring eeprom code out of the
> network drivers at some point.
I have no problem with this, but it has to be done right.
> -ben
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
