Jeff Garzik wrote:
>Patrick J. LoPresti wrote:
>> Hi. I couldn't help but notice that the de4x5 driver in Linux 2.6.9
>> defines a "de4x5_pci_tbl" structure but does not invoke
>> MODULE_DEVICE_TABLE(pci, de4x5_pci_tbl).
>>
>> Consequently, the de4x5 driver is not listed in
>> /lib/modules/2.6.9/modules.pcimap as I would expect.
>>
>> Is this deliberate?
>
>Yes, that's intentional.
>
> Jeff
To clarify Jeff's response, de2104x.c supposedly
drives the "tulip" and "tulip plus" chips better, so omitting
the MODULE_DEVICE_TABLE() declaration from de4x5.c should
result in the de2104x driver being used instead on systems
that use modules.pcimap.
Unfortunately, only de4x5.c claims to support "tulip
fast" and "dec 21142" as far as I can tell. So, perhaps we
should add a MODULE_DEVICE_TABLE() line to de4x5.c, but comment
out the entries for tulip and tulip plus in de4x5.c.
More elaborate solutoins are possible, such as by making de4x5.c
a library that export de4x5_pci_{probe,remove} and then
having two separate microscopic driver modules for
tulip/tulip-plus and tulip-fast/dec21142 respectively, but
I don't know if there is a user base of people who actually
use de4x5.c on tulip or tulip plus. To avoid being accused
of volunteering other people, I add that I'm willing to write
the patch to do either of these if there is a willingness to
incorporate it and someone to test it.
__ ______________
Adam J. Richter \ /
adam@yggdrasil.com | g g d r a s i l
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
