"Thank you" to whoever ported drivers/atm/horizon.c to the
modern PCI probing interface in linux-2.6.10-rc1-bk6 (or some
previous 10-rc1-bk release). However, one minor detail was
missed. The driver should have a MODULE_DEVICE_TABLE()
declaration so that boot and hotplug systems that match PCI
device ID's to kernel modules will properly load the module
when the hardware is detected. Here is the one line patch.
I'm not quite sure who to submit it to, so I would appreciate
it if someone would tell me that they've forwarded it upstream. I
tried to search the archives for the horizon.c patch that appeared
in the recent 2.6.10-rc1-bk release so I could contact the author of
it, but I was unsuccessful.
__ ______________
Adam J. Richter \ /
adam@yggdrasil.com | g g d r a s i l
--- linux-2.6.10-rc1-bk7/drivers/atm/horizon.c 2004-10-28 20:51:49.000000000 -0700
+++ linux/drivers/atm/horizon.c 2004-10-28 18:50:48.000000000 -0700
@@ -2910,10 +2910,11 @@
static struct pci_device_id hrz_pci_tbl[] = {
{ PCI_VENDOR_ID_MADGE, PCI_DEVICE_ID_MADGE_HORIZON, PCI_ANY_ID, PCI_ANY_ID,
0, 0, 0 },
{ 0, }
};
+MODULE_DEVICE_TABLE(pci, hrz_pci_tbl);
static struct pci_driver hrz_driver = {
.name = "horizon",
.probe = hrz_probe,
.remove = __devexit_p(hrz_remove_one),
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
