On Sun, 15 Aug 2004 23:31:50 -0700 "David S. Miller" <davem@redhat.com> wrote: > I can't even figure out why this change makes a difference, but > I will investigate it some more. Thanks a lot. Tony, please revert your patch and try this one instead. Does it make your MTU changing test case work? ===== drivers/net/tg3.c 1.192 vs edited ===== --- 1.192/drivers/net/tg3.c 2004-08-16 17:41:48 -07:00 +++ edited/drivers/net/tg3.c 2004-08-16 17:46:04 -07:00 @@ -400,9 +400,10 @@ tr32(MAILBOX_INTERRUPT_0 + TG3_64BIT_REG_LOW); } -static inline void tg3_cond_int(struct tg3 *tp) +static inline void tg3_cond_int(struct tg3 *tp, int force) { - if (tp->hw_status->status & SD_STATUS_UPDATED) + if ((tp->hw_status->status & SD_STATUS_UPDATED) || + force) tw32(GRC_LOCAL_CTRL, tp->grc_local_ctrl | GRC_LCLCTRL_SETINT); } @@ -413,7 +414,7 @@ tw32_mailbox(MAILBOX_INTERRUPT_0 + TG3_64BIT_REG_LOW, 0x00000000); tr32(MAILBOX_INTERRUPT_0 + TG3_64BIT_REG_LOW); - tg3_cond_int(tp); + tg3_cond_int(tp, 0); } static inline void tg3_netif_stop(struct tg3 *tp) @@ -430,7 +431,7 @@ * (such as after tg3_init_hw) */ netif_poll_enable(tp->dev); - tg3_cond_int(tp); + tg3_cond_int(tp, 1); } static void tg3_switch_clocks(struct tg3 *tp) - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html