On Mon, 1 Mar 2004, David S. Miller wrote: > On Mon, 01 Mar 2004 14:52:35 +0100 > John Williams Floroiu <floroiu@fokus.fraunhofer.de> wrote: > > > currently one receives RTMGRP_DEL_ROUTE notifications only when the routes are explicitly brought > > down with "ip route del ...". but if a local route is deleted by the kernel as result to an inteface > > being brought down with "ip li set ... down", no notification is received by clients listening to > > RTMGRP_DEL_ROUTE. > > Then this appears to be the bahavior to change, isn't it? :-) Not to be picky but wasn't it this which was proposed in the first message in this thread, including a "quick and dirty" patch for doing so? http://marc.theaimsgroup.com/?l=linux-net&m=107703393609842&w=2 The RTMGRP_DEL_ROUTE notifications is only sent in fn_hash_delete, not fn_hash_flush. So any routes deleted by other means than fn_hash_delete will go unnotified. But I cannot say I fully understand the proposed patch. Does not look like the correct place to address this in, but maybe it is? What about multilink routes? In addition it looks to me this will duplicate notifications already sent on normal route deletes. But I have to admit I can not immediately see any obvious better candidate. Feels like these ought to be sent from fib_sync_up/down, but.. Perhaps a acceptable level can be reached if the patch is extended with a filter to only sent notifications when RTNH_F_DEAD (or not RTNH_F_ZOMBIE) routes are flushed? The RTNH_F_ZOMBIE ones should already have been notified in fn_hash_delete and is not interesting to send yet another notification on these I think. And in addition, shouln't rtmsg_fib be used to construct the message rather than fib_dump_info etc? Regards Henrik - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
