On Sat, Jul 12, 2003 at 12:33:55AM -0700, David S. Miller wrote: > > We're not going to fix this by hardcoding rules about > IPIP and IPCOMP in generic xfrm code. When I start to see > tests for IPIP and IPCOMP in xfrm_policy.c I start to be > afraid :-) Fair enough. I've changed the offending test to if (xfrm_state_kern(x)) return tmpl->mode && tmpl->optional && xfrm_state_addr_cmp(tmpl, x, family); Is this clean enough? It does have the side effect that IPCOMP users must set the optional flag. But that is the status quo anyway. -- Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ ) Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html