Re: [IPV6] Fix refcnt leak in addrconf regen timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 09, 2003 at 09:44:50PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> 
> Hmm, please try this.
> 
> Index: net/ipv6/addrconf.c
> ===================================================================
> RCS file: /home/cvs/linux-2.5/net/ipv6/addrconf.c,v
> retrieving revision 1.44
> diff -u -r1.44 addrconf.c
> --- net/ipv6/addrconf.c	1 Jul 2003 16:42:06 -0000	1.44
> +++ net/ipv6/addrconf.c	9 Jul 2003 11:23:32 -0000
> @@ -1907,6 +1907,27 @@
>  	/* Step 3: clear address list */
>  
>  	write_lock_bh(&idev->lock);
> +#ifdef CONFIG_IPV6_PRIVACY
> +	if (del_timer(&idev->regen_timer))
> +		in6_dev_put(idev);

Is it OK to delete the timer even if how == 0?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux