3c527.c needs a patch?

["Angelo Dell'Aera" <buffer@antifork.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Auditing kernel 2.5.73 sources I found in drivers/net/3c527.c
this section of code repeated few times.

[..]
        save_flags(flags);
        cli();

        while(lp->exec_pending)
                sleep_on(&lp->event);

        /*
         *      Issue mine
         */

        lp->exec_pending=1;

        restore_flags(flags);
[..]

Is there a particular reason for not using a spin_lock_irqsave/restore
(thus avoiding cli() )?. Moreover, in situations like this I think it's
better to use wait_event() on the condition. If needed I can send a
patch on it.


Regards.

Angelo Dell'Aera 
Antifork Research, Inc.	  	http://buffer.antifork.org

PGP information in e-mail header


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE++bHUpONIzxnBXKIRAtxiAJ9snBbRvAQIZDTxNu4B3r1OGrzo/ACghEJx
epGoTFLxaPtPBlxSgnk677U=
=j70P
-----END PGP SIGNATURE-----
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html