Re: bug in ip_finish_output2 ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 09, 2001 at 08:27:01AM -0700, Akshay Adhikari wrote:
> So are we assuming that the header length is always 
> 16? (magic number)

It's upto 16 bytes. It should probably be a define.

> 
> And after that, we push skb->data back by hh->hh_len. 
> Does this value equal 16? 

It can be less.

> Either the data size used in skb_push should be 16, 
> or the memcpy should use hh_len. 
> 
> Whats the purpose of doing it differently? 

Constant size memcpys are faster.

-Andi
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux