On Mon, Apr 09, 2001 at 08:27:01AM -0700, Akshay Adhikari wrote: > So are we assuming that the header length is always > 16? (magic number) It's upto 16 bytes. It should probably be a define. > > And after that, we push skb->data back by hh->hh_len. > Does this value equal 16? It can be less. > Either the data size used in skb_push should be 16, > or the memcpy should use hh_len. > > Whats the purpose of doing it differently? Constant size memcpys are faster. -Andi - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org